Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message on promoting encrypted dataset #8935

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

tcaputi
Copy link
Contributor

@tcaputi tcaputi commented Jun 19, 2019

This patch corrects the error messgae reported when attempting
to promote a dataset outside of its encryption root.

Fixes: #8905

Signed-off-by: Tom Caputi tcaputi@datto.com

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jun 19, 2019
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally the patch looks good just a few comments.

lib/libzfs/libzfs_dataset.c Outdated Show resolved Hide resolved
lib/libzfs/libzfs_dataset.c Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #8935 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8935      +/-   ##
==========================================
- Coverage   78.86%   78.74%   -0.13%     
==========================================
  Files         388      382       -6     
  Lines      120055   117777    -2278     
==========================================
- Hits        94683    92745    -1938     
+ Misses      25372    25032     -340
Flag Coverage Δ
#kernel 79.32% <0%> (-0.21%) ⬇️
#user 67.67% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050d720...3f55f14. Read the comment docs.

This patch corrects the error messgae reported when attempting
to promote a dataset outside of its encryption root.

Fixes: 8905

Signed-off-by: Tom Caputi <tcaputi@datto.com>
@tcaputi tcaputi force-pushed the fix_promote_error branch from e59377d to 3f55f14 Compare June 20, 2019 15:25
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 24, 2019
@behlendorf behlendorf requested a review from tonyhutter June 24, 2019 17:07
@behlendorf behlendorf merged commit 5386480 into openzfs:master Jun 24, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
This patch corrects the error message reported when attempting
to promote a dataset outside of its encryption root.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8905
Closes openzfs#8935
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
This patch corrects the error message reported when attempting
to promote a dataset outside of its encryption root.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8905
Closes openzfs#8935
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
This patch corrects the error message reported when attempting
to promote a dataset outside of its encryption root.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8905
Closes openzfs#8935
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
This patch corrects the error message reported when attempting
to promote a dataset outside of its encryption root.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8905
Closes openzfs#8935
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
This patch corrects the error message reported when attempting
to promote a dataset outside of its encryption root.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8905
Closes openzfs#8935
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
This patch corrects the error message reported when attempting
to promote a dataset outside of its encryption root.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #8905
Closes #8935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zfs promote of encrypted clone outside its encryption root gives bad error message
2 participants